Algorithm Harmonization #6 KF, main branch (2026.06.22.)#1355
Open
krasznaa wants to merge 12 commits into
Open
Algorithm Harmonization #6 KF, main branch (2026.06.22.)#1355krasznaa wants to merge 12 commits into
krasznaa wants to merge 12 commits into
Conversation
krasznaa
force-pushed
the
KFHarmonization-main-20260515
branch
2 times, most recently
from
5f3d39c to
7ecd4b3
Compare
krasznaa
commented
Jun 23, 2026
Comment on lines
+31
to
+34
| const device::fit_payload& payload, const device::fit_tpayload< | ||
| fitter::detector_type::const_view_type, | ||
| fitter::bfield_type, | ||
| fitter::surface_type>* tpayload); |
Member
Author
There was a problem hiding this comment.
Ahh, forgot that pre-commit does not format these files...
While also making device::fit_prelude non-templated. As the EDM related templating should go away completely in the future anyway.
While rewriting how arguments would be passed to device::fit_forward and device::fit_backward.
To get code highlighting and formatting for those files in the editor.
krasznaa
force-pushed
the
KFHarmonization-main-20260515
branch
from
7ecd4b3 to
3aeac82
Compare
|
stephenswat
requested changes
Jun 26, 2026
stephenswat
left a comment
stephenswat
left a comment
Member
There was a problem hiding this comment.
The code doesn't look bad but I am once again asking you to please stop trying to sneak in unrelated changes into this codebase under the guise of meaningful improvements.
Comment on lines
+5
to
+6
| "*.ipp": "cpp", | ||
| "*.cu.in": "cpp" |
Comment on lines
+116
to
119
| if (!is<obj_t>()) { | ||
| throw std::bad_any_cast(); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Is there a really, really good reason why you feel that splitting this code into an .ipp file should be done in this PR? Because if not, this is really just polluting what is already a sufficiently complicated changeset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started working on this a while ago, but thought that I'd hold off with it until the move to the acts repository.
But @niermann999 told me that her ongoing development could possibly make use of the "harmonized" code. So, here we go.
Indeed, as we discussed with @niermann999, one needs to pass "detector specific" payloads between the kernels during fitting. I actually forgot last week that I had "a solution" for this already. As I use an internal polymorphic payload type for this purpose.
Have a look! Let's see if it works for you!