ref: Move bfield dependency to tests#980
Merged
Merged
Conversation
niermann999
force-pushed
the
ref-move-bfield
branch
11 times, most recently
from
e40e565 to
c5a4211
Compare
niermann999
added
blocked
niermann999
force-pushed
the
ref-move-bfield
branch
3 times, most recently
from
2c83881 to
29a665f
Compare
niermann999
force-pushed
the
ref-move-bfield
branch
from
29a665f to
1d2b33b
Compare
niermann999
force-pushed
the
ref-move-bfield
branch
2 times, most recently
from
eb53fc1 to
3523ff6
Compare
Collaborator
Author
|
Needed as a prerequisite to acts-project/traccc#966 |
niermann999
force-pushed
the
ref-move-bfield
branch
from
3523ff6 to
9b88183
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the covfie dependency to the test, so that covfie only gets set up if tests, benchmarks or tutorials are selected.
The test sub-libraries are reoredered according to their dependencies and client use cases:
test_common(depends on covfie): Contains test detectors, bfield and track generators, as e.g. needed by the benchmarks or tutorialstest_utils(no external dependencies): lightweight utils for extended testing, e.g. inspectors, specialized actors, multiple-scattering tools (for traccc simulation)validation_utils(depends on actsvg and csv IO): Large validation suites for navigation and materialtest_framework(depends on google test): Tools needed to run detray unit and integration testsMost changes come down to renaming or removing dependencies (like moving the validation configs to the validation utils lib and removing any dependencies on the test_framework), but should stay detray-internal (see e.g. acts-project/traccc#948 for the amount of downstream changes).
The removal of the gtest dependency also allows to use the validation tools in traccc and acts without requiring gtest for no reason