Skip to content

Update PR comment behavior for on-failure mode#941

Open
sgmurphy wants to merge 2 commits intoactions:mainfrom
sgmurphy:update-pr-comment
Open

Update PR comment behavior for on-failure mode#941
sgmurphy wants to merge 2 commits intoactions:mainfrom
sgmurphy:update-pr-comment

Conversation

@sgmurphy
Copy link
Copy Markdown
Contributor

@sgmurphy sgmurphy commented Jun 17, 2025 •
edited
Loading

Summary

Changes

  • Modified comment-pr.ts to handle success cases in on-failure mode by updating existing comments
  • Added hasExistingComment helper function to check for existing dependency review comments
  • Added comprehensive test suite covering all comment modes and scenarios

Test plan

  • All existing tests pass
  • New tests cover all comment modes (always, never, on-failure)
  • Tests verify proper comment creation, updating, and skipping behavior
  • Edge cases handled (non-PR context, multiple comments)

Demo

Live demonstration of the enhanced functionality:

Demo 1: Enhanced on-failure mode behavior

sgmurphy/fictional-garbanzo#1

  • Demonstrates improved comment behavior in on-failure mode
  • Shows comment creation when vulnerabilities are found
  • Shows comment updating (not creating new ones) when vulnerabilities are resolved
  • Prevents comment spam by reusing existing comments

Demo 2: never mode validation

sgmurphy/fictional-garbanzo#2

  • Validates that comment-summary-in-pr: never properly suppresses all comments
  • Even with vulnerabilities present, no PR comments are created
  • Ensures "never" mode works correctly with the enhanced logic

@sgmurphy
Update PR comment behavior for on-failure mode
f21eb50 
When comment_summary_in_pr is set to 'on-failure', the action now updates
existing comments when issues are resolved in subsequent runs, providing
clear feedback that dependency issues have been fixed.
@sgmurphy sgmurphy force-pushed the update-pr-comment branch from fb6f77d to f21eb50 Compare June 17, 2025 20:57
@sgmurphy sgmurphy marked this pull request as ready for review June 17, 2025 20:58
@sgmurphy sgmurphy requested a review from a team as a code owner June 17, 2025 20:58
@sgmurphy sgmurphy mentioned this pull request Aug 2, 2025
Open
@sgmurphy
Copy link
Copy Markdown
Contributor Author

sgmurphy commented Aug 2, 2025

Hey @dangoor 👋 , any chance I could get a review 👀 on this?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 30, 2026

👋 This pull request has been marked as stale because it has been open with no activity for 180 days. You can: comment on the PR or remove the stale label to hold stalebot off for a while, add the Keep label to hold stale off permanently, or do nothing. If you do nothing, this pull request will be closed eventually by the stalebot. Please see CONTRIBUTING.md for more policy details.

@github-actions github-actions bot added the Stale label Jan 30, 2026
@niebloomj
Copy link
Copy Markdown

niebloomj commented Jan 30, 2026

This is still very important to me!

@github-actions github-actions bot removed the Stale label Jan 31, 2026
@johnSmithTech
Copy link
Copy Markdown

johnSmithTech commented Apr 2, 2026

Hey @sgmurphy ,

Came across your GitHub profile while checking recent PR activity — really liked your work 👀

Quick question — do PR reviews ever slow you down?

I’m building Mesrai AI — it connects to GitHub and reviews PRs and changes instantly (bugs, improvements, suggestions) before human review.

You can try it here — free & quick setup (~1 min):

Mesrai AI
Mesrai

Would really appreciate your feedback — I’m building this to solve real PR review problems, and your input would be super valuable 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mark previous PR comment as outdated

4 participants

@sgmurphy @niebloomj @johnSmithTech @brrygrdn