Prevent creating duplicate files if assets and public stream is in same path.#67
Open
nmdaz wants to merge 1 commit into
Open
Prevent creating duplicate files if assets and public stream is in same path.#67nmdaz wants to merge 1 commit into
nmdaz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Site Studio’s file scanning process could create duplicate file_managed records for the same physical file. This happened when asset:// and public:// pointed to the same directory, but asset:// was processed first. In that case, Site Studio stored the file using an asset:// URI instead of matching the existing public:// record, resulting in duplicate file entities and incorrect file usage tracking.
Proposed changes
Sort the stream wrappers in FileUsage::__construct() so public is always processed first when converting file paths to stream wrapper URIs. This ensures files resolve consistently to public://, preventing duplicate file entities from being created for the same file.
No updates or migrations are required. Existing duplicate records created before this fix may still need manual cleanup.