refactor: replace deprecated forEachGesture with awaitEachGesture#344
Open
saadkhalidkhan wants to merge 5 commits into
Open
refactor: replace deprecated forEachGesture with awaitEachGesture#344saadkhalidkhan wants to merge 5 commits into
saadkhalidkhan wants to merge 5 commits into
Conversation
saadkhalidkhan
force-pushed
the
fix/await-each-gesture
branch
from
84f8e0f to
14af6b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eachGestureWhileActivefor the channel-based drag loop inReorderable.ktwhere arbitrary suspend calls (channel receive) are requireddetectReorderanddetectReorderAfterLongPresstoawaitEachGestureAwaitPointerEventScopeoverload for long-press detection so it works insideawaitEachGestureCloses #253
Commits
eachGestureWhileActivehelper (forEachGesture replacement)AwaitPointerEventScopelong press overloaddetectReordertoawaitEachGesturedetectReorderAfterLongPresstoawaitEachGestureforEachGestureinReorderable.ktTest plan
./gradlew :reorderable:compileKotlinJvmpasses with no deprecation warnings./gradlew :android:assembleDebugpasses