Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
InteractiveUtilspackage to resolve issues with thesubtypesfunction, used insideavailable_datasets, which returns the list of datasets exposed by SoleData.Artifacts (NatOps, Libras, HuGaDb, Epilepsy).available_datasetsandload_dataset.Manifest.tomlfile from the docs directory.Manifest.tomlfiles.Issue Identified
The test for
load_datasetfails, not because the dataset cannot be loaded, but because of the expected return type, which isTuple{<:AbstractDataFrame, <:CategoricalArray}. This return type is fine for NatOps, Libras, and Epilepsy but not for HuGaDb, which loads aTuple{DataFrames.DataFrame, Tuple{Vector{SubString{String}}, Vector{Int64}}, Vector{String}}.This type mismatch triggers the failure. It needs to be clarified whether:
Additional Observations
HuGaDb contains duplicated labels (e.g., multiple "walking" and "standing"). It is unclear if this is intended, but it is worth noting.