[Biobank] Normalize biobank validation strings and fix Center/Site mismatch#10720
Merged
driusan merged 3 commits intoJun 30, 2026
Merged
Conversation
github-actions
Bot
added
the
Language: Javascript
driusan
approved these changes
Jun 30, 2026
Collaborator
|
@HenriRabalais Can you remove the now unused from French and Japanese so that the po file matches the pot: This field is required! |
github-actions
Bot
added
the
Multilingual
kongtiaowang
pushed a commit
to kongtiaowang/Loris
that referenced
this pull request
Jul 2, 2026
…smatch (aces#10720) Cleans up inconsistent punctuation and whitespace on the biobank validation messages, and fixes two `Center`/`Site` mismatches where the code string didn't match the fr/zh `.po` msgids (so those translations never resolved). Also corrects a malformed `.pot` entry and adds three strings that were missing from the template. - Fixed malformed entry `Parent Specimen(s, {ns: 'biobank'})` → `Parent Specimen(s)`. - Added `Container`, `Draw Site`, and `Parent Specimen(s)`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleans up inconsistent punctuation and whitespace on the biobank
validation messages, and fixes two
Center/Sitemismatches where thecode string didn't match the fr/zh
.pomsgids (so those translationsnever resolved). Also corrects a malformed
.potentry and adds threestrings that were missing from the template.
Changes
Validation strings (
jsx/biobankIndex.js)The same messages were written several different ways (
.,!,!,trailing spaces), which created duplicate msgids and broke translation
matching. Collapsed each to a single form:
This field must be a number.This field is required.This field must be a valid date.This field must be a valid time.Center → Site
jsx/batchEditForm.js:Specimens must be of the same Type and Sitejsx/poolSpecimenForm.js:...PSCID, Visit Label, Type and SiteThe fr and zh
.pomsgids already used "Site", but the code emitted"Center", so neither translation resolved. The code now matches the
existing translations.
locale/biobank.pot!/!msgid blocks into the singleperiod-form entries.
Parent Specimen(s, {ns: 'biobank'})→Parent Specimen(s).Container,Draw Site, andParent Specimen(s).