Skip to content

Fix Behavioural QC feedback status and links#10698

Open
Montekkundan wants to merge 1 commit into
aces:mainfrom
Montekkundan:montek/10268-behavioural-qc-feedback
Open

Fix Behavioural QC feedback status and links#10698
Montekkundan wants to merge 1 commit into
aces:mainfrom
Montekkundan:montek/10268-behavioural-qc-feedback

Conversation

@Montekkundan

Copy link
Copy Markdown
Contributor

Brief summary of changes

  • Hides closed behavioural feedback threads from the Behavioural QC feedback table.
  • Routes instrument-level feedback links through instrument_list with commentID and showFeedback=true.
  • Passes commentID into the instrument list feedback panel so BMI instrument feedback opens the correct thread.
  • Keeps feedback threads visible even when the feedback type lookup row is missing.

Testing instructions

  • Open http://localhost:8080/behavioural_qc/#tabBehaviouralFeedback.
  • Confirm active/non-closed feedback rows appear in the Behavioural Feedback table.
  • Open the BMI feedback row for 300017 / MTL017 / BMI Calculator and confirm it opens instrument_list, not /instruments/bmi/.
  • Confirm the feedback panel opens and shows the BMI thread.
  • Close that thread, refresh Behavioural QC, and confirm the closed row no longer appears.

Link(s) to related issue(s)

@Montekkundan Montekkundan self-assigned this Jun 28, 2026
@github-actions github-actions Bot added Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: behavioural_qc PR or issue related behavioural_qc module Module: instrument_list PR or issue related to instrument_list module labels Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Module: behavioural_qc PR or issue related behavioural_qc module Module: instrument_list PR or issue related to instrument_list module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[behavioural_qc] Shows opened for all issues

1 participant