Skip to content

[modules | candidate_parameters] Fix DoB page loading for EDC-only participants#10688

Open
priyavrat7 wants to merge 3 commits into
aces:29.0-releasefrom
priyavrat7:2026_06_22_EDC_Failing_Fix
Open

[modules | candidate_parameters] Fix DoB page loading for EDC-only participants#10688
priyavrat7 wants to merge 3 commits into
aces:29.0-releasefrom
priyavrat7:2026_06_22_EDC_Failing_Fix

Conversation

@priyavrat7

@priyavrat7 priyavrat7 commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown

This PR fixes #10644

Situation

  • The DoB tab failed to load for participants created with an EDC but without a recorded DoB.
  • A TypeError was thrown when DateTime::createFromFormat() received a null value.

Task

  • Ensure the DoB tab loads correctly for EDC-only participants.
  • Prevent failures when candidate DoB values are null.

Action

  • Added a null-safe date formatting helper.
  • Updated DoB date formatting logic to handle null values before attempting date conversion.

Result

  • The DoB and DoD(aditional fix) tabs now loads successfully for EDC-only participants.
  • The candidateDOB endpoint returns HTTP 200 instead of a server error.
  • Existing participants with valid DoB values continue to function correctly.
image

Testing

  • Admin -> Configuration -> Study -> Use EDC (make it yes) and click Submit
  • Candidate -> New Profile > Create new profile with EDC only (leave DoB blank) > click create and also note down the candidate details
  • Candidate -> Access Profile -> Search for the newly created EDC candidate -> Click on PSCID Link -> Candidate Info -> DoB and it loads DoB

@priyavrat7
Fix DoB page loading for EDC-only participants
d8ffa69 
Prevent DateTime::createFromFormat() from being called with a
null DoB value by introducing a null-safe date formatting helper.
The DoB tab now loads correctly when a participant has an EDC
but no recorded date of birth.
@priyavrat7 priyavrat7 added Category: Bug PR or issue that aims to report or fix a bug Language: PHP PR or issue that update PHP code Module: candidate_profile PR or issue related to candidate_profile module 29.0.0 - Bugs Issues found during the release testing for 29.0.0 labels Jun 23, 2026
@github-actions github-actions Bot added the Module: candidate_parameters PR or issue related to candidate_parameters module label Jun 23, 2026
@priyavrat7 priyavrat7 changed the base branch from main to 29.0-release June 23, 2026 05:12
@priyavrat7 priyavrat7 removed the Module: candidate_profile PR or issue related to candidate_profile module label Jun 23, 2026
@priyavrat7
Fix DoD page as well now to load for EDC-only participants
50a9b33 
Prevent DateTime::createFromFormat() from being called(similar
issue like DoB) with a null DoB value by introducing a null-safe
date formatting helper. The DoD tab now loads correctly when a
participant has an EDC but no recorded date of birth.
@priyavrat7 priyavrat7 changed the title [modules | candidate_profiles] Fix DoB page loading for EDC-only participants [modules | candidate_parameters] Fix DoB page loading for EDC-only participants Jun 23, 2026
@CamilleBeau CamilleBeau added the Priority: High PR or issue should be prioritised over others for review and testing label Jun 25, 2026
@CamilleBeau CamilleBeau requested a review from adamdaudrich June 29, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ridz1208 ridz1208 Awaiting requested review from ridz1208
@CamilleBeau CamilleBeau Awaiting requested review from CamilleBeau
@adamdaudrich adamdaudrich Awaiting requested review from adamdaudrich

At least 1 approving review is required to merge this pull request.

Assignees

@adamdaudrich adamdaudrich

Labels

29.0.0 - Bugs Issues found during the release testing for 29.0.0 Category: Bug PR or issue that aims to report or fix a bug Language: PHP PR or issue that update PHP code Module: candidate_parameters PR or issue related to candidate_parameters module Priority: High PR or issue should be prioritised over others for review and testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[configuration][candidate_parameters] Use EDC failing in candidate profile

3 participants

@priyavrat7 @CamilleBeau @adamdaudrich