[create_timepoint] fixing invalid error message - #10669
Closed
fias06 wants to merge 5 commits into
Closed
Conversation
github-actions
Bot
added
Language: PHP
fias06
added
Module: create_timepoint
fias06
force-pushed
the
2026_06_19_invalid_error_message_createTimepoint
branch
from
June 19, 2026 17:49
680ef6a to
c77ce98
Compare
fias06
force-pushed
the
2026_06_19_invalid_error_message_createTimepoint
branch
2 times, most recently
from
June 19, 2026 18:55
9cc3142 to
95e1d8d
Compare
skarya22
requested changes
Jul 13, 2026
skarya22
left a comment
skarya22
left a comment
Contributor
There was a problem hiding this comment.
@fias06 I think this is not actually an issue -- a participant cannot have multiple visits with the same visit_label. If anything, the error message could be improved make it more clear that duplicate visits are not allowed, but this solution would break loris logic elsewhere.
If you still want to solve the issue can you undo these changes and make the error message better? Otherwise you can close the PR and the issue
skarya22
added
the
State: Needs work
Contributor
Author
|
Okay thanks I can close the issue and PR for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Fixed a false error that the timepoint exists for the given selections even though it did not.
Testing instructions (if applicable)
Link(s) to related issue(s)