Skip to content

Add mapping datatype for configuration settings#10555

Open
Montekkundan wants to merge 2 commits into
aces:mainfrom
Montekkundan:montek/10458-config-mapping-clean
Open

Add mapping datatype for configuration settings#10555
Montekkundan wants to merge 2 commits into
aces:mainfrom
Montekkundan:montek/10458-config-mapping-clean

Conversation

@Montekkundan

Copy link
Copy Markdown
Contributor

Brief summary of changes

  • Adds a mapping configuration datatype for settings that store source values with mapped external values.
  • Adds ConfigMappings schema support, upgrade/drop SQL, and raisinbread seed data for visit mappings.
  • Updates the Configuration module UI and save path so mapping rows can be added, edited, removed, and persisted.
CleanShot 2026-06-14 at 22 53 26@2x

Testing instructions (if applicable)

  • Open http://localhost:8080/configuration/ and confirm Visit Mappings renders with paired value / mapped value inputs.
  • Add a new visit mapping, submit, and confirm it persists after reload.
  • Edit an existing mapped value, submit, and confirm the updated value persists after reload.
  • Remove a mapping row and confirm it is removed from the page and database.

Link(s) to related issue(s)

@Montekkundan Montekkundan self-assigned this Jun 15, 2026
@github-actions github-actions Bot added Language: SQL PR or issue that update SQL code RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: configuration PR or issue related to configuration module labels Jun 15, 2026

@skarya22 skarya22 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice functionality!
There seems to be nothing warning the user if they try to save a mapping with just one value and not both sides of the pair, though it is not saved. I think there should be validation to not let you submit if it's incomplete -- OR it should save with it incomplete (if validation is too hard / adds too much code)
Right now it doesnt save but also doesnt tell you it wont save which is confusing

@skarya22 skarya22 added the State: Needs work PR awaiting additional work by the author to proceed label Jun 16, 2026
@Montekkundan

Copy link
Copy Markdown
Contributor Author

Added validation so mapping rows with only one side filled cannot be submitted

@Montekkundan Montekkundan requested a review from skarya22 June 18, 2026 23:27
@skarya22 skarya22 assigned skarya22 and unassigned Montekkundan Jun 23, 2026
@skarya22 skarya22 removed the State: Needs work PR awaiting additional work by the author to proceed label Jun 23, 2026

@skarya22 skarya22 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@skarya22 skarya22 added the Passed manual tests PR has been successfully tested by at least one peer label Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Language: SQL PR or issue that update SQL code Module: configuration PR or issue related to configuration module Passed manual tests PR has been successfully tested by at least one peer RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[configuration] Create Mapping Type Option

2 participants