Add mapping datatype for configuration settings#10555
Open
Montekkundan wants to merge 2 commits into
Open
Conversation
skarya22
requested changes
Jun 16, 2026
skarya22
left a comment
Contributor
There was a problem hiding this comment.
Nice functionality!
There seems to be nothing warning the user if they try to save a mapping with just one value and not both sides of the pair, though it is not saved. I think there should be validation to not let you submit if it's incomplete -- OR it should save with it incomplete (if validation is too hard / adds too much code)
Right now it doesnt save but also doesnt tell you it wont save which is confusing
Contributor
Author
|
Added validation so mapping rows with only one side filled cannot be submitted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
mappingconfiguration datatype for settings that store source values with mapped external values.ConfigMappingsschema support, upgrade/drop SQL, and raisinbread seed data for visit mappings.Testing instructions (if applicable)
http://localhost:8080/configuration/and confirmVisit Mappingsrenders with paired value / mapped value inputs.Link(s) to related issue(s)