fix: get notification running with merkls list of bookmarks#63
Merged
manuelsanchez2 merged 10 commits intomainfrom May 6, 2026
Merged
fix: get notification running with merkls list of bookmarks#63manuelsanchez2 merged 10 commits intomainfrom
manuelsanchez2 merged 10 commits intomainfrom
Conversation
… proceed custom events or not Ref: ENG-843
Contributor
|
I like it, fix the tests and make the type consistent and you'll get my approval! |
Ref: ENG-843
Ref: ENG-843
dkreitschmann
force-pushed
the
refactor/notifications-in-bookmarks
branch
from
fa19397 to
db173f1
Compare
Ref: ENG-843
Ref: ENG-483
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Die Notifications sollen natürlich auch auf der Bookmarkseite funcktionieren. Damit das klappt, müssen die Notifications mit der Bookmark-Api in zeit.web zusammen spielen. Dieser PR tut das Nötige, damit das klappt.
Testen: Die Demopage muss weiterhin funktionieren.
Gifs