fix(recording): honor the selected save folder - #664
Open
themaddoxed wants to merge 6 commits into
Open
Conversation
22 tasks
themaddoxed
marked this pull request as ready for review
July 21, 2026 19:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a native Choose Folder action next to Open Folder and makes the persisted recording root apply to all future live recordings and future audio imports.
Behavior
folder_pathand are not moved.folder_selected: true; no filesystem path is sent.Related Issue
Fixes #481
Related to #516. This PR covers the same live-recording and import paths while adding transactional persistence, fail-fast destination handling, race protection, privacy-safe analytics, and focused tests.
Type of Change
Testing
Clean
upstream/devtestbranch:pnpm run buildpassed.Source build with browser-test infrastructure:
pnpm exec tsc --noEmitpassed.pnpm run buildpassed.Known upstream baseline checks outside this diff:
devtestRust suite has one exact-duration float assertion failure:159.999996ms != 160msinaudio::device_detection::tests::test_calculate_buffer_timeout_bluetooth. This PR does not modify that file.tsc --noEmitondevtestreports the existing missingbun:testdeclaration intests/lib/blocknote-markdown.test.ts; the production Next.js build passes type checking.Documentation
Checklist