Add missing package file to the site preview widget#78583
Merged
Conversation
retrofox
added
[Type] Experimental
|
Size Change: -57 B (0%) Total Size: 8.04 MB 📦 View Changed
ℹ️ View Unchanged
|
Member
|
The |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
No, it's wrong. The file is there, Manzoor. |
Member
Oh yeah, sorry, it looks like my local git state was stale. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds the missing workspace
package.jsonto the Site Preview dashboard widget (widgets/site-preview/) and declares the dependencies it imports.Follow-up to #78556, which added the widget without a workspace
package.json. It applies the convention raised in the review of #78408 (#78408 (review)): each widget workspace should declare all the dependencies it uses.Why?
Every other dashboard widget (
activity,hello-world,quick-draft,welcome) is a workspace with its ownpackage.jsondeclaring its dependencies. Site Preview was merged without one, so it neither declares the packages it imports nor registers as a workspace member.How?
widgets/site-preview/package.json(@wordpress/site-preview-widget), matching the format of the sibling widgets.render.tsx:@wordpress/components,@wordpress/core-data,@wordpress/data,@wordpress/element,@wordpress/i18n,@wordpress/ui.widget.ts:@wordpress/icons,@wordpress/i18n.npm installregisters the workspace (symlink undernode_modules/@wordpress/site-preview-widget+ lockfile entry), consistent with the other widgets.Testing Instructions
npm install.node_modules/@wordpress/site-preview-widgetis a symlink towidgets/site-preview.