pr: [Nightly Fix] - Bug - Use gmdate() for Subscription Transaction Timestamps#59
Open
jewel-claw wants to merge 1 commit into
Open
Conversation
…imestamps
PaymentSuccessHandler::processSubscriptionsSuccess() used date() to format
the Stripe invoice timestamp for created_at/updated_at fields. date() applies
the server's local timezone, while the rest of the codebase consistently uses
gmdate() (UTC) for Stripe-sourced timestamps and current_time('mysql') for
WordPress-local timestamps.
This caused subscription transaction timestamps to be stored in the server's
local timezone instead of UTC, making them inconsistent with all other records
in the same table (StripeHandler and processOnetimeSuccess both use gmdate).
On a server with a non-UTC timezone, this would result in timestamps that are
offset by hours relative to the actual event time and other records.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PaymentSuccessHandler::processSubscriptionsSuccess()used PHP'sdate()function to format the Stripe invoice'screatedUnix timestamp for thecreated_atandupdated_atfields.date()applies the server's local timezone. Every other timestamp derived from Stripe event data in this codebase usesgmdate()(UTC):StripeHandler::handleInlineSubscriptions():gmdate('Y-m-d H:i:s', ...)PaymentSuccessHandler::processOnetimeSuccess():gmdate('Y-m-d H:i:s', ...)Effect: On a server configured with a non-UTC timezone (e.g., Asia/Dhaka at UTC+6), subscription transaction timestamps would be stored 6 hours ahead of UTC — inconsistent with all other Stripe-derived timestamps in the same
wpf_subscription_transactionstable.Fix: Replace
date()withgmdate()to match the rest of the codebase.