Skip to content

pr: [Nightly Fix] - Security - Secure Admin Image Upload #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jewel-claw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

pr: [Nightly Fix] - Security - Secure Admin Image Upload #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions includes/Classes/GlobalSettingsHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@ public function handleEndpoints()
{
$route = sanitize_text_field($_REQUEST['route']);

if ($route !== 'wpf_upload_image') {
wpfValidateNonce('wpf_admin_nonce');
}
wpfValidateNonce('wpf_admin_nonce');

$routes = array(
'get_global_currency_settings' => 'getGlobalCurrencySettings',
Expand Down Expand Up @@ -94,15 +92,16 @@ protected function handleFileUpload()
if (!function_exists('wp_handle_upload')) {
require_once(ABSPATH . 'wp-admin/includes/file.php');
}
$uploadedfile = $_FILES['file'];
if (empty($_FILES['file']) || empty($_FILES['file']['tmp_name'])) {
wp_send_json_error(__('Please upload a valid image file', 'wppayform'), 423);
}

$acceptedFilles = array(
'image/png',
'image/jpeg'
);
$uploadedfile = $_FILES['file'];
$fileType = wp_check_filetype_and_ext($uploadedfile['tmp_name'], $uploadedfile['name']);
$acceptedExtensions = array('jpg', 'jpeg', 'png');

if (!in_array($uploadedfile['type'], $acceptedFilles)) {
wp_send_json(__('Please upload only jpg/png format files', 'wppayform'), 423);
if (empty($fileType['ext']) || !in_array($fileType['ext'], $acceptedExtensions, true)) {
wp_send_json_error(__('Please upload only jpg/png format files', 'wppayform'), 423);
}

$upload_overrides = array('test_form' => false);
Expand Down
2 changes: 1 addition & 1 deletion includes/Classes/Menu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ public function enqueueAssets()
'wpf_admin_nonce' => wp_create_nonce('wpf_admin_nonce'),
'paymentStatuses' => GeneralSettings::getPaymentStatuses(),
'entryStatuses' => GeneralSettings::getEntryStatuses(),
'image_upload_url' => admin_url('admin-ajax.php?action=wpf_global_settings_handler&route=wpf_upload_image'),
'image_upload_url' => admin_url('admin-ajax.php?action=wpf_global_settings_handler&route=wpf_upload_image&wpf_admin_nonce=' . wp_create_nonce('wpf_admin_nonce')),
'forms_count' => Forms::getTotalCount(),
'assets_url' => WPPAYFORM_URL.'assets/',
'has_pro' => defined('WPPAYFORMHASPRO') && WPPAYFORMHASPRO,
Expand Down