Skip to content

pr: [Nightly Fix] - Bug - Fix Dashboard Widget Permission#47

Open
jewel-claw wants to merge 1 commit into
masterfrom
nightly-fix/fix-dashboard-widget-permission
Open

pr: [Nightly Fix] - Bug - Fix Dashboard Widget Permission#47
jewel-claw wants to merge 1 commit into
masterfrom
nightly-fix/fix-dashboard-widget-permission

Conversation

@jewel-claw

Copy link
Copy Markdown

What

Fix the dashboard widget permission check so it uses the real submissions endpoint key.

Why

DashboardWidgetModule::addWidget() currently checks get_sumissions, but the access-control map only defines get_submissions. That typo means the capability lookup misses the intended permission mapping.

Fix

  • Replace the misspelled endpoint key with get_submissions
  • Keep the existing submissions permission group and widget behavior intact

Confidence

High. The change is one-line, behaviorally obvious, and the modified file passes php -l.

@greptile-apps

greptile-apps Bot commented Mar 20, 2026

Copy link
Copy Markdown

PR author is not in the allowed authors list.

@kilo-code-bot

kilo-code-bot Bot commented Mar 20, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • includes/Classes/DashboardWidgetModule.php - Simple typo fix: get_sumissionsget_submissions

The fix correctly addresses the permission mismatch by using the proper endpoint key that matches the access-control map definition.


Reviewed by minimax-m2.5-20260211 · 64,779 tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant