pr: [Nightly Fix] - Bug - Fix Dashboard Widget Permission#47
Open
jewel-claw wants to merge 1 commit into
Open
Conversation
|
PR author is not in the allowed authors list. |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
The fix correctly addresses the permission mismatch by using the proper endpoint key that matches the access-control map definition. Reviewed by minimax-m2.5-20260211 · 64,779 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix the dashboard widget permission check so it uses the real submissions endpoint key.
Why
DashboardWidgetModule::addWidget()currently checksget_sumissions, but the access-control map only definesget_submissions. That typo means the capability lookup misses the intended permission mapping.Fix
get_submissionsConfidence
High. The change is one-line, behaviorally obvious, and the modified file passes
php -l.