pr: [Nightly Fix] - Bug - Harden Form Creation Flow#44
Open
jewel-claw wants to merge 1 commit into
Open
Conversation
|
PR author is not in the allowed authors list. |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
The changes are well-designed:
Reviewed by minimax-m2.5-20260211 · 119,741 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix the admin form creation flow so blank titles still create a default-named form and failed inserts return a proper JSON error without trying to update a non-existent post.
Why
The current handler returns early when
post_titleis blank, which leaves the AJAX caller without a response. It also callswp_update_post()before checking whetherForms::create()returned aWP_Error, which can produce follow-up warnings and hides the real failure.Fix
Blank Formfallback titlewp_update_post()Confidence
High. The change is small, isolated to the create-form AJAX path, and
php -lpasses on the modified file.