pr: [Nightly Fix] - Null Safety - Guard Missing Submission View#39
Open
jewel-claw wants to merge 1 commit into
Open
pr: [Nightly Fix] - Null Safety - Guard Missing Submission View#39jewel-claw wants to merge 1 commit into
jewel-claw wants to merge 1 commit into
Conversation
|
PR author is not in the allowed authors list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The admin submission detail endpoint assumes
getSubmission()always returns a record and dereferences it immediately.Why
An invalid or deleted submission ID can trigger a fatal null-property access instead of a clean JSON error.
Fix
Return a
Sorry, No Submission foundJSON error before reading submission properties when the lookup fails.Confidence
Confirmed in code review and validated with
php -lon the modified file.