Skip to content

pr: [Nightly Fix] - Bug - Fix Blank Form Creation#38

Open
jewel-claw wants to merge 1 commit into
masterfrom
nightly-fix/create-form-blank-title
Open

pr: [Nightly Fix] - Bug - Fix Blank Form Creation#38
jewel-claw wants to merge 1 commit into
masterfrom
nightly-fix/create-form-blank-title

Conversation

@jewel-claw

Copy link
Copy Markdown

What

Creating a form without a title sets Blank Form and then returns before the form is created.

Why

That makes the blank-form fallback path fail silently instead of creating the form the UI expects.

Fix

Keep the fallback title, but do not return early. The request now continues through the normal form creation flow.

Confidence

Confirmed in code review and validated with php -l on the modified file.

@greptile-apps

greptile-apps Bot commented Mar 12, 2026

Copy link
Copy Markdown

PR author is not in the allowed authors list.

if (!$postTitle) {
$postTitle = 'Blank Form';
return;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRITICAL: Logic bug - early return removed

The return; statement was removed from this if block. This changes the behavior:

  • Old behavior: If $_REQUEST['post_title'] is empty, set title to 'Blank Form' and RETURN early (don't create form)
  • New behavior: If $_REQUEST['post_title'] is empty, set title to 'Blank Form' and CONTINUE to create the form

This appears to be an unintended change. If the intent was to allow blank forms, this is correct. But if the original behavior (rejecting empty titles) was intended, the return; needs to be restored.

@kilo-code-bot

kilo-code-bot Bot commented Mar 12, 2026

Copy link
Copy Markdown

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 1
WARNING 0
SUGGESTION 0
Issue Details (click to expand)

CRITICAL

File Line Issue
includes/Classes/AdminAjaxHandler.php 80 Early return removed - changes form creation behavior
Files Reviewed (1 file)
  • includes/Classes/AdminAjaxHandler.php - 1 issue

Fix these issues in Kilo Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant