pr: [Nightly Fix] - Security - Validate Tools Ajax Nonce#37
Open
jewel-claw wants to merge 1 commit into
Open
Conversation
|
PR author is not in the allowed authors list. |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Overview
AnalysisThis PR adds CSRF protection to the The change:
This follows the same pattern used in other methods in this class ( Files Reviewed (1 file)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The tools AJAX router accepted the
upload_formaction without validating the admin nonce.Why
That left the form import endpoint open to CSRF from another site for authenticated admins with tools access.
Fix
Validate
wpf_admin_nonceinGlobalTools::handleEndPoint()before dispatching any route. Existing per-route nonce checks remain compatible.Confidence
Confirmed in code review and validated with
php -lon the modified file.