fix PermissionsViewer 'View Role Members'#4202
Open
meowpurrpur wants to merge 4 commits into
Open
Conversation
Owner
|
I kind of overlooked the fact that BetterRoleContext needs its patch to function... This is indeed a fix but I'm not sure if I like making BetterRoleContext a dependency of PermissionViewer |
Author
|
Ah alright, i'll look at fixing it another way |
Author
|
@Vendicated would the updated fix I made be better than adding it as a dependency? i don't have much experience with plugins and stuff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4192
Add BetterRoleContext as a dependency for PermissionsViewer.
The “View Role Members” button added by PermissionsViewer relies on the RoleMemberPopout hook implemented by BetterRoleContext. Without the plugin enabled, the popout renders without any members.
This makes BetterRoleContext a required dependency for the feature to function correctly.