Skip to content

PermissionsViewer: sort roles by hierarchy, users alphabetically#4194

Open
Vexify4103 wants to merge 1 commit into
Vendicated:devfrom
Vexify4103:claude/thirsty-hawking-1af7d0
Open

PermissionsViewer: sort roles by hierarchy, users alphabetically#4194
Vexify4103 wants to merge 1 commit into
Vendicated:devfrom
Vexify4103:claude/thirsty-hawking-1af7d0

Conversation

@Vexify4103
Copy link
Copy Markdown

Currently the roles/users list in the permissions modal is unsorted, making it hard to find a specific user or role at a glance.

This change sorts the list alphabetically by name within each type group (roles first, then members), re-sorting reactively when member data finishes loading.

@Vendicated
Copy link
Copy Markdown
Owner

Ordering alphabetically doesnt make that much sense either imo. If anything it should be ordered by hierarchy, i.e. highest role first

@Vexify4103
Copy link
Copy Markdown
Author

What if we do roles per hierarchy and users alphabetically?

@Vendicated
Copy link
Copy Markdown
Owner

sounds good

@Vexify4103 Vexify4103 force-pushed the claude/thirsty-hawking-1af7d0 branch from 62bae92 to 4234d11 Compare May 6, 2026 15:13
@Vexify4103
Copy link
Copy Markdown
Author

Also what do we think of the idea of adding a toggle button, which would allow switching from usernames to nicknames?
The current system only does discord usernames.

@Vexify4103 Vexify4103 force-pushed the claude/thirsty-hawking-1af7d0 branch from 4234d11 to 376c5c5 Compare May 7, 2026 17:34
@Vexify4103 Vexify4103 changed the title PermissionsViewer: sort roles and users alphabetically by name PermissionsViewer: sort roles by hierarchy, users alphabetically; add nickname toggle May 7, 2026
@Vexify4103 Vexify4103 force-pushed the claude/thirsty-hawking-1af7d0 branch from 376c5c5 to f1e02e6 Compare May 7, 2026 18:03
@Vendicated Vendicated changed the base branch from main to dev May 8, 2026 14:58
@Vendicated Vendicated requested a review from Nuckyz May 8, 2026 15:01
@Vendicated
Copy link
Copy Markdown
Owner

Seems pretty over-engineered, like AI code usually is

@Vexify4103
Copy link
Copy Markdown
Author

Yeah I used claude to do this pr. The username sorting alphabetically is good, you already approved. The nickname stuff is pretty over engineered. I can remove it if you want.

@Vexify4103 Vexify4103 force-pushed the claude/thirsty-hawking-1af7d0 branch 2 times, most recently from 17f4650 to 708cb80 Compare May 10, 2026 13:18
@Vexify4103 Vexify4103 force-pushed the claude/thirsty-hawking-1af7d0 branch from 708cb80 to 3631712 Compare May 14, 2026 02:18
@Vexify4103 Vexify4103 changed the title PermissionsViewer: sort roles by hierarchy, users alphabetically; add nickname toggle PermissionsViewer: sort roles by hierarchy, users alphabetically May 14, 2026
@Vexify4103
Copy link
Copy Markdown
Author

I’ve gone ahead and removed the nickname toggle change now.
Idk if I should open a new PR for that change, but it feels more right to keep this PR focused on the original quality of life improvement instead of adding extra complexity for no real reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants