ReviewDB: fix emoji picker close behavior#4148
Open
Thereallo1026 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hii
I noticed that I couldn't exit the emoji picker in the ReviewDB modal by clicking outside of the frame
ReviewDB uses Discord's user profile reply text area inside a modal. Discord's native user profile reply input passes
emojiPickerCloseOnModalOuterClick, so this PR mirrors that behavior for ReviewDB's review input.Repro:
Before this change, the picker stayed open until pressing esc or selecting an emoji