fix(converter): move keep_data_uris to convert call and fix lint#165
Merged
Conversation
Collaborator
|
Thanks for the fix, @RussellLuo — I verified it end-to-end (a PPTX with an embedded image now yields img_001.png where 0.4.3 dropped it), and it's green across ruff/mypy/pytest. Merging now. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry about that. In PR #163, the code I verified locally did not match what I actually committed, and I also had not run the test locally. This follow-up fixes the incorrect change and the leftover lint issue.