win32u/vulkan: Move 'features' to function scope in vkCreateDevice.#328
Open
nanomatters wants to merge 1 commit into
Open
win32u/vulkan: Move 'features' to function scope in vkCreateDevice.#328nanomatters wants to merge 1 commit into
nanomatters wants to merge 1 commit into
Conversation
VkPhysicalDeviceFeatures features is declared inside an inner {} block
in win32u_vkCreateDevice, but its address is stashed into
create_info->pEnabledFeatures and then dereferenced after the block ends
by convert_device_create_info() and the host vkCreateDevice call. This
was exposed when compiled using gcc16 and caused game crashes.
Originated in c67d194 ("fshack: win32u: Support vulkan scaling
according to fake resolution.").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VkPhysicalDeviceFeatures features is declared inside an inner {} block
in win32u_vkCreateDevice, but its address is stashed into
create_info->pEnabledFeatures and then dereferenced after the block ends
by convert_device_create_info() and the host vkCreateDevice call. This
was exposed when compiled using gcc16 and caused game crashes.
Originated in c67d194 ("fshack: win32u: Support vulkan scaling
according to fake resolution.").