feat(cas): add check to lint for unlocalized strings in cas components#60
Open
scottcmg wants to merge 4 commits intofeature/cas-parityfrom
Open
feat(cas): add check to lint for unlocalized strings in cas components#60scottcmg wants to merge 4 commits intofeature/cas-parityfrom
scottcmg wants to merge 4 commits intofeature/cas-parityfrom
Conversation
…tart (#52) * feat(cas): add disabled features, first run, and loading from existing conversation support * chore(cas): add new config props to story * remove testing artifact
scottcmg
force-pushed
the
feature/cas-parity
branch
from
c0189d1 to
cfff866
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a script to check for unlocalized strings in CAS components that will be rendered in the UI
Adds the script to the lint check
Updates contributors guide for how to localize, what is allowed and what is not, and escape hatch patterns for dynamic strings
A few other clean up changes to clear up lint warnings/failures
Test
Run
npm run lintand ensure run is clean and ignores unlocalized strings in other widgets.