feat: isolate inner schema to avoid name collisions#388
Merged
andreitava-uip merged 1 commit intomainfrom Jan 5, 2026
Merged
Conversation
f1088b3 to
57a9b60
Compare
Collaborator
There was a problem hiding this comment.
this type of loop cross cutting functionality we should maybe extract in a /common package at the same level as /react as to be reused and not duplicated
Contributor
Author
There was a problem hiding this comment.
true but for now i'd rather not prematurely extract packages when the hierarchy itself is not clearly defined. It should be easily done at a later date. If the plan is for us to reuse it within different loops of ours, we should think about where it should stay. If we want it to be usable by users directly (although in my opinion it is currently implemented with our state management in mind), it's a different story.
57a9b60 to
86e8867
Compare
cotovanu-cristian
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: