Default to parquet + keep_zip=True, refresh README, fix NEXT_DAY URL#96
Closed
nick-gorman wants to merge 1 commit into
Closed
Default to parquet + keep_zip=True, refresh README, fix NEXT_DAY URL#96nick-gorman wants to merge 1 commit into
nick-gorman wants to merge 1 commit into
Conversation
Replaces the single-line mention of accepted input forms with a proper subsection under Dynamic data compiler. Documents all three forms (string, datetime.datetime, datetime.date) with a concrete code example for each, and calls out the date-expansion edge case (end_time as a bare date is inclusive of the whole day, because parse_datetime_py expands it to 00:00:00 of the next day). Also switches the two existing datetime() examples in the headline Dynamic data compiler example and the Accessing additional table columns example to string literals, since strings are the simplest form and don't require a datetime import. Added TOC entry for the new subsection. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
Author
|
Closing — branch was behind master, the 6 earlier commits already landed via PR #95. Re-opening as a fresh single-commit PR off the new master tip. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Seven commits accumulated on the
keep-zip-default-truebranch since master. Grouped by intent:Behavioural / default changes
45285d2(already on remote — origin/keep-zip-default-true tip when this PR was assembled)keep_zipdefault flipped fromFalsetoTruefordynamic_data_compiler/cache_compiler. Closes Option to keep .zip not csv #56 — cached zips survive between runs.1f034a7fformatdefault flipped fromfeathertoparquet. Feather still supported viafformat='feather'. Includes README + test-suite updates so the offline suite stays green.Fixture / source bug fix
6e65ea5FixNEXT_DAY_DISPATCHLOADURL after AEMO renamed the parent directory + bump therecentfixture era to 2026-05-15.fdb0b60Extend the test fixture matrix with a2026-04era so the boundary tests carry general recent-month coverage in thePUBLIC_ARCHIVE#format.Docs
30eba59Sync README with the caching defaults already on master (keep_csv=False,keep_zip=True). The previous README still claimedkeep_csv=True. Added thekeep_csv×keep_zipretention matrix.cea80f0Fix incorrect "GUI co-use needskeep_csv=True" claim. The GUI reads parquet/feather, not the raw AEMO CSV —keep_csvis purely for external CSV consumers.679f598Drop a dangling rationale clause from one matrix row so the matrix is symmetric (just describes contents; the "leanest" / "full" markers stay on rows 2 and 4).53c1b66New "Start and end time" subsection documenting the three accepted input forms (string,datetime.datetime,datetime.date) with a code example for each. Includes thedate-expansion edge case (end_timeas a bare date is inclusive of the whole day).Test plan
NEXT_DAY_DISPATCHLOAD(offline suite already covers the URL-fix path via fixtures)dynamic_data_compilerwith no explicitfformatnow writes parquet to a fresh cache directory🤖 Generated with Claude Code