Replaced instances of boost::bind with std::bind or lambda functions.#3410
Conversation
wmostrenko
requested review from
itsarune,
sauravbanna and
williamckha
as code owners
itsarune
requested review from
a team,
DimitriK24 and
someone2060
and removed request for
a team
itsarune
left a comment
itsarune
left a comment
There was a problem hiding this comment.
good work!
Can you delete the lines #include boost/bind.hpp and the @boost//::bind from the BUILD files?
Also docs/coroutine_test_examples.cpp still uses boost::bind
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Replaced instances of boost::bind with std::bind
itsarune
left a comment
itsarune
left a comment
There was a problem hiding this comment.
merge conflicts + you can delete all of these lines:
…re into boost_bind_to_std_bind
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR was closed because it has been stalled for 5 days with no activity. |
GrayHoang
left a comment
GrayHoang
left a comment
There was a problem hiding this comment.
Very nice, this removes the deprecation message spamming whenever we build stuff right?
Looked for boost references with grep as well, only found stuff in old bazel cache.
…into boost_bind_to_std_bind
GrayHoang
left a comment
GrayHoang
left a comment
There was a problem hiding this comment.
looks good just needed a master merge before
4 participants
Please fill out the following before requesting review on this PR
Description
Replaced instances of boost::bind with std::bind or lambda functions throughout the codebase.
Testing Done
Resolved Issues
Resolves #3299
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue