Example play to FSM#3402
Merged
williamckha merged 37 commits intoMay 15, 2025
Merged
Conversation
Remove Qt dependency from ER Force Simulator (UBC-Thunderbots#3311)
Merge main project to own branch
…cessary Files still need to be refactored, which will be done in the next commit
… `halt_tactic.h`, renaming variables and strings where necessary Variables and strings renamed for consistency and to allow tests to successfully run
…t`, renaming where necessary
`example_play_fsm.cpp` and associated files have not been implemented; planned to be implemented next commit
Still giving errors, as `example_play_fsm.cpp` has not been implemented
…play-to-fsm # Conflicts: # src/software/ai/hl/stp/play/example/example_play_fsm.h
Debugging still necessary, as the `example_play_test.cpp` is not passing
test case works now yippee
someone2060
requested review from
itsarune,
sauravbanna and
williamckha
as code owners
someone2060
requested review from
a team,
GrayHoang and
axiev1
and removed request for
a team
williamckha
reviewed
Oct 29, 2024
williamckha
left a comment
williamckha
left a comment
Member
There was a problem hiding this comment.
Great work! The FSM looks good to me, just two comments
…2060/UBC-Thunderbots-Software into exampleplay-to-fsm
…into exampleplay-to-fsm
itsarune
reviewed
Feb 15, 2025
| cc_library( | ||
| name = "all_plays", | ||
| deps = [ | ||
| <<<<<<< HEAD |
Contributor
There was a problem hiding this comment.
looks like you've got merge conflict markers in here. Needs merge conflict fixing
itsarune
reviewed
Feb 15, 2025
| from proto.ssl_gc_common_pb2 import Team | ||
|
|
||
|
|
||
| # TODO issue #2599 - Remove Duration parameter from test |
Contributor
There was a problem hiding this comment.
this issue does not seem to exist. we may not need it
itsarune
reviewed
Feb 15, 2025
Comment on lines
+73
to
+79
| [RobotSpeedEventuallyBelowThreshold(1e-3)] | ||
| ], | ||
| ag_always_validation_sequence_set=[[]], | ||
| ag_eventually_validation_sequence_set=[ | ||
| [RobotSpeedEventuallyBelowThreshold(1e-3)] | ||
| ], | ||
| test_timeout_s=10, |
Contributor
There was a problem hiding this comment.
instead, I think you should assert that the robots come within a 1 m radius of the ball
itsarune
reviewed
Feb 15, 2025
itsarune
left a comment
itsarune
left a comment
Contributor
There was a problem hiding this comment.
looks like you have a bad merge that you need to fix
Contributor
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Contributor
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
williamckha
previously approved these changes
May 15, 2025
GrayHoang
approved these changes
May 15, 2025
GrayHoang
left a comment
GrayHoang
left a comment
Contributor
There was a problem hiding this comment.
Previous approval carries forward
williamckha
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill out the following before requesting review on this PR
Description
Converts the Example Play from a co-routine to an FSM.
The example play was moved to its own folder, with appropriate BUILD files modified. This was done to maintain consistency with other FSMs.
Testing Done
example_play_test.cppsuccessfully passed, and Example Play successfully ran on Thunderscope.Resolved Issues
resolves #3298
Length Justification and Key Files to Review
example_play.cppand corresponding.hfileexample_play_fsm.cppand corresponding.hfileexample/BUILDReview Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue