Fix anchor links not scrolling in mobile hamburger menu#3121
Open
emmyKcodes wants to merge 1 commit into
Open
Conversation
emmyKcodes
force-pushed
the
fix/mobile-menu-anchor-scroll
branch
from
3b87f85 to
783045c
Compare
emmyKcodes
force-pushed
the
fix/mobile-menu-anchor-scroll
branch
from
783045c to
31b42bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Tapping an anchor link in the mobile sidebar menu updated the URL hash but didn't scroll to the target.
Root cause
.has-menu body { overflow: hidden }is still active when the browser tries to do its native scroll-to-hash, since Toggle.ts doesn't close the menu (and lift the scroll lock) until a 250ms setTimeout later. By then the native scroll opportunity has passed.Fix
Toggle.ts now manually calls
scrollIntoView()on the target after closing the menu, instead of relying on the browser's one-shot native scroll.Testing
Verified on [device/browser] that tapping sidebar anchors now scrolls correctly.
Fixes #3049