-
Notifications
You must be signed in to change notification settings - Fork 371
fix(ui): scope last workspace cookie by user #2793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
daryllimyt
wants to merge
1
commit into
main
Choose a base branch
from
codex/find-issue-with-last-workspace-storage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import Cookies from "js-cookie" | ||
|
|
||
| const LAST_WORKSPACE_COOKIE_PREFIX = "__tracecat:workspaces:last-viewed" | ||
| const LEGACY_LAST_WORKSPACE_COOKIE = LAST_WORKSPACE_COOKIE_PREFIX | ||
|
|
||
| function userLastWorkspaceCookieName(userId: string): string { | ||
| return `${LAST_WORKSPACE_COOKIE_PREFIX}:${encodeURIComponent(userId)}` | ||
| } | ||
|
|
||
| /** | ||
| * Reads the client-side last viewed workspace ID for a specific user. | ||
| * | ||
| * Anonymous callers use the legacy shared cookie, but authenticated users use a | ||
| * user-scoped cookie so switching accounts in the same browser does not leak the | ||
| * previously selected workspace across users. | ||
| */ | ||
| export function getLastWorkspaceIdForUser(userId?: string): string | undefined { | ||
| if (!userId) { | ||
| return Cookies.get(LEGACY_LAST_WORKSPACE_COOKIE) | ||
| } | ||
| return Cookies.get(userLastWorkspaceCookieName(userId)) | ||
| } | ||
|
|
||
| /** Stores the client-side last viewed workspace ID for a specific user. */ | ||
| export function setLastWorkspaceIdForUser( | ||
| userId: string | undefined, | ||
| workspaceId?: string | ||
| ) { | ||
| const cookieName = userId | ||
| ? userLastWorkspaceCookieName(userId) | ||
| : LEGACY_LAST_WORKSPACE_COOKIE | ||
|
|
||
| if (!workspaceId) { | ||
| Cookies.set(cookieName, "") | ||
| return | ||
| } | ||
| Cookies.set(cookieName, workspaceId) | ||
| } | ||
|
|
||
| /** Clears the client-side last viewed workspace ID for a specific user. */ | ||
| export function clearLastWorkspaceIdForUser(userId?: string) { | ||
| if (!userId) { | ||
| Cookies.remove(LEGACY_LAST_WORKSPACE_COOKIE) | ||
| return | ||
| } | ||
| Cookies.remove(userLastWorkspaceCookieName(userId)) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| /** | ||
| * @jest-environment jsdom | ||
| */ | ||
|
|
||
| import Cookies from "js-cookie" | ||
| import { | ||
| clearLastWorkspaceIdForUser, | ||
| getLastWorkspaceIdForUser, | ||
| setLastWorkspaceIdForUser, | ||
| } from "@/lib/last-workspace" | ||
|
|
||
| describe("last workspace persistence", () => { | ||
| beforeEach(() => { | ||
| Cookies.remove("__tracecat:workspaces:last-viewed") | ||
| Cookies.remove("__tracecat:workspaces:last-viewed:user-a") | ||
| Cookies.remove("__tracecat:workspaces:last-viewed:user-b") | ||
| }) | ||
|
|
||
| it("stores the last workspace separately for each user", () => { | ||
| setLastWorkspaceIdForUser("user-a", "workspace-a") | ||
| setLastWorkspaceIdForUser("user-b", "workspace-b") | ||
|
|
||
| expect(getLastWorkspaceIdForUser("user-a")).toBe("workspace-a") | ||
| expect(getLastWorkspaceIdForUser("user-b")).toBe("workspace-b") | ||
| }) | ||
|
|
||
| it("keeps anonymous storage on the legacy shared cookie", () => { | ||
| setLastWorkspaceIdForUser(undefined, "workspace-anonymous") | ||
| setLastWorkspaceIdForUser("user-a", "workspace-a") | ||
|
|
||
| expect(getLastWorkspaceIdForUser()).toBe("workspace-anonymous") | ||
| expect(getLastWorkspaceIdForUser("user-a")).toBe("workspace-a") | ||
| }) | ||
|
|
||
| it("clears only the scoped user's last workspace", () => { | ||
| setLastWorkspaceIdForUser("user-a", "workspace-a") | ||
| setLastWorkspaceIdForUser("user-b", "workspace-b") | ||
|
|
||
| clearLastWorkspaceIdForUser("user-a") | ||
|
|
||
| expect(getLastWorkspaceIdForUser("user-a")).toBeUndefined() | ||
| expect(getLastWorkspaceIdForUser("user-b")).toBe("workspace-b") | ||
| }) | ||
| }) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Using
!userIdto select the legacy cookie conflates anonymous and auth-loading states, so authenticated sessions can still hit the shared cookie before user data resolves.Prompt for AI agents