Fix with incorrect User.Comments Layer Name with Cmts.User#97
Open
MiniProjectDIY wants to merge 1 commit intoTousstNicolas:masterfrom
Open
Fix with incorrect User.Comments Layer Name with Cmts.User#97MiniProjectDIY wants to merge 1 commit intoTousstNicolas:masterfrom
MiniProjectDIY wants to merge 1 commit intoTousstNicolas:masterfrom
Conversation
"User.Comments" is a layer name displayed in Footprint Editor,but should be "Cmts.User" inside the kicad_mod file. Refer: https://gitlab.com/kicad/code/kicad/-/blame/master/qa/data/pcbnew/sliver.kicad_pcb#L20
|
Why not map the "Component shape layer" to F.Fab? It seems more appropriate. |
Contributor
Author
pls refer to #94 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"User.Comments" is a layer name displayed in Footprint Editor,but should be "Cmts.User" inside the kicad_mod file. Refer:
https://gitlab.com/kicad/code/kicad/-/blame/master/common/lset.cpp#L131
https://gitlab.com/kicad/code/kicad/-/blame/master/qa/data/pcbnew/sliver.kicad_pcb#L20
Sorry for previous commit,I've double confirmed this one on my own project.