fix(observability): render skipped pipeline steps - #1562
Open
GuddXzy wants to merge 1 commit into
Open
Conversation
Author
|
Thanks for the focused fix and regression tests. I checked the current main branch, and skipped steps are still rendered as CI, PR body lint, and PR target branch currently show |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Scope boundary: Render the documented skipped-by-gate pipeline step state as
SKIPPEDin read-only replay transcripts, while preserving existingOKandFAIL(<reason>)output.Non-goals: Change pipeline execution, decision-log persistence/schema, other replay fields, or unrelated CLI output.
Branch
Base branch: main
Target exception: N/A
Issue
Linked issue: Fixes #1503
If None, reason: N/A
Release Note
Release note: Replay transcripts now distinguish conditionally skipped pipeline steps from failures.
Tests
Ruff:
uv run ruff check src tests— passedPytest:
uv run pytest -q tests/test_observability/test_replay.py tests/test_observability/test_decision_log_contract.py— 7 passeduv run pytest -q tests/test_observability— 193 passed, 1 skippedpytest -vv -xwas a functional gateway SQLitedisk I/O errorintest_real_gateway_suppresses_goal_sentinel_everywhereafter 351 passed and 8 skipped. Upstream CI provides the repository's sharded Ubuntu and selected Windows coverage.Build:
npm --prefix opensquilla-webui run build— passeduv build --wheel— passedRegression tests: added
Notes: The regression matrix covers
OK,SKIPPED,FAIL(boom), and an empty failure reason rendered asFAIL(). The implementation intentionally checksfallback_reason is Nonerather than truthiness.The default test path remains offline, deterministic, credential-free, and safe for forks.
Maintainer Live Check
Maintainer live check: no
Surface: N/A
Maintainer-only note: no credentialed live check is needed for the read-only replay formatter.
Safety
No secrets, local-only artifacts, private prompts/transcripts, channel identifiers, AI session artifacts, non-public fixtures, or
tests/_private/contents are included.Third-Party Origin
Third-party origin: none
Details if non-none: N/A
Documentation Changes
No documentation changes. The existing pipeline contract already names this state
skipped-by-gate; this PR corrects the renderer to match it.