Scope pending attachments to committed chat sessions

opensquilla-webui/e2e/attachment-drag-upload.spec.ts

@@ -1,4 +1,10 @@
 import { expect, test, type Download, type Page } from '@playwright/test'
+import {
+  chatHistoryPayload,
+  sessionMessagesHydratePayload,
+  sessionMessagesSnapshotPayload,
+  sessionMessagesSubscribePayload,
+} from './support/session-read-fixtures'
 
 const CONTROL_URL = '/control/chat/new'
 const HISTORY_IMAGE_DATA = 'iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mP8/x8AAwMCAO+/p9sAAAAASUVORK5CYII='
@@ -42,10 +48,21 @@ async function mockRpc(page: Page, capturedSends: CapturedSend[], options: MockR
     ws.onMessage(message => {
       try {
         const frame = JSON.parse(String(message))
+        if (frame?.type === 'ping') {
+          ws.send(JSON.stringify({ type: 'pong' }))
+          return
+        }
         if (frame?.type !== 'req') return
         const method = String(frame.method || '')
+        const sessionKey = String(frame.params?.key || frame.params?.sessionKey || '')
         if (method === 'connect') {
-          ws.send(JSON.stringify({ protocol: 3, policy: { tick_interval_ms: 30000 } }))
+          ws.send(JSON.stringify({
+            protocol: 3,
+            policy: {
+              tick_interval_ms: 30000,
+              concurrent_history_reads: true,
+            },
+          }))
           return
         }
         if (method === 'chat.send') {
@@ -78,7 +95,7 @@ async function mockRpc(page: Page, capturedSends: CapturedSend[], options: MockR
         }
         if (method === 'chat.history') {
           options.historyRequests?.push(frame.params || {})
-          ws.send(wsResponse(String(frame.id), { messages: historyMessages, has_more: false }))
+          ws.send(wsResponse(String(frame.id), chatHistoryPayload(historyMessages)))
           return
         }
 
@@ -91,12 +108,9 @@ async function mockRpc(page: Page, capturedSends: CapturedSend[], options: MockR
             skills: {},
           },
           'sessions.list': { sessions: [], has_more: false },
-          'sessions.messages.subscribe': {
-            subscribed: true,
-            replay_complete: true,
-            current_stream_seq: 0,
-            run_status: 'idle',
-          },
+          'sessions.messages.snapshot': sessionMessagesSnapshotPayload(sessionKey),
+          'sessions.messages.subscribe': sessionMessagesSubscribePayload(sessionKey),
+          'sessions.messages.hydrate': sessionMessagesHydratePayload(sessionKey),
           'usage.status': { sessions: [] },
         }
 

opensquilla-webui/src/components/chat/ChatComposer.i18n.test.ts

@@ -1,7 +1,7 @@
 // @vitest-environment happy-dom
 
 import { afterEach, describe, expect, it } from 'vitest'
-import { createApp, nextTick } from 'vue'
+import { createApp, h, nextTick, ref } from 'vue'
 
 import i18n, { loadLocaleMessages } from '@/i18n'
 import type { Attachment } from '@/types/chat'
@@ -35,6 +35,46 @@ afterEach(() => {
 })
 
 describe('ChatComposer attachment localization', () => {
+  it('renders and removes the intended attachment when recovered and new IDs differ', async () => {
+    const attachments = ref<Attachment[]>([
+      {
+        kind: 'staged',
+        local_id: -1,
+        name: 'recovered.txt',
+        mime: 'text/plain',
+        file_uuid: 'recovered-upload',
+      },
+      {
+        kind: 'staged',
+        local_id: 1,
+        name: 'new.txt',
+        mime: 'text/plain',
+        file_uuid: 'new-upload',
+      },
+    ])
+    const el = document.createElement('div')
+    document.body.appendChild(el)
+    const app = createApp({
+      render: () => h(ChatComposer, {
+        ...BASE_PROPS,
+        attachments: attachments.value,
+        onRemoveAttachment: (index: number) => attachments.value.splice(index, 1),
+      } as any),
+    })
+    app.use(i18n)
+    app.mount(el)
+    await nextTick()
+
+    expect([...el.querySelectorAll('.attachment-chip__name')].map(node => node.textContent))
+      .toEqual(['recovered.txt', 'new.txt'])
+    el.querySelectorAll<HTMLButtonElement>('.attachment-remove')[0]?.click()
+    await nextTick()
+    expect([...el.querySelectorAll('.attachment-chip__name')].map(node => node.textContent))
+      .toEqual(['new.txt'])
+
+    app.unmount()
+  })
+
   it('localizes failed status, fallback file label, and retry accessibility text', async () => {
     await loadLocaleMessages('zh-Hans')
     i18n.global.locale.value = 'zh-Hans'