fix(chatform): Do not interpret 祝 and 秘 as smiley.#699
Conversation
|
Tip Preview URL: |
bcb1695 to
9f47bd8
Compare
9f47bd8 to
4d27e31
Compare
4d27e31 to
74d2c16
Compare
74d2c16 to
43bf715
Compare
43bf715 to
144b208
Compare
144b208 to
4e413d3
Compare
|
What is the status of this one? |
4e413d3 to
942ed73
Compare
942ed73 to
30b98a1
Compare
30b98a1 to
8da424e
Compare
I have pushed more changes to fix static analysis errors. I think, it is ready now. The only failing test is related to Bazel issue. |
8da424e to
8b18c32
Compare
8b18c32 to
3f2ba70
Compare
6f2cd82 to
e876e37
Compare
e876e37 to
3017170
Compare
3017170 to
d314993
Compare
d314993 to
9f68b5d
Compare
9f68b5d to
4b154c9
Compare
I have pushed the fix, but it seems, we have issues with Codacy. Is it configured through UI (It does not seems, we have .codacy.yml)? The linter has both D212 and D213 enabled, which are mutually exclusive. There is also inconsistency in Arguments processing, that results in two errors in codacy. |
4b154c9 to
3a2537a
Compare
I cant see "D213", but it is supposed to follow https://peps.python.org/pep-0257/#multi-line-docstrings anyway, so lets get it back to that state and then we look at the ci again. Codacy sadly only shows the last scan for a pr. The linter in question is |
3a2537a to
32fb32c
Compare
32fb32c to
cf89ed4
Compare
cf89ed4 to
daa4d27
Compare
daa4d27 to
371a750
Compare
371a750 to
6282853
Compare
I see. In have ran I have set In some places I have suppressed D407, because if the docstring contains Args:, but rthere is no Return section, it results in failure. I.e. there is no underline under Args: section; section could not contain colon., however will result in error about undocumented parameter "param", because now args is just a section, but not the Arguments description. @Green-Sky, I have synced the PR could you please take another look? |
6282853 to
a8f181e
Compare
I have updated the
update_smileys.pyscript so that we can block and unblock smiley without loosing information. I have used the script for removing 祝 and 秘. See #613.This change is