Fix a few issues with CoreTemperature and add HSI#124
Conversation
- Read Heat Strain Index from Core Temperature data (if available). - Store "reserved" in a field. Contents are not clear. - Fix typo in data class name (Cote -> Core) - Set value to None for invalid values.
|
Failed check must be unrelated, a re-run from someone with permissions should fix it. |
Yes undecided here too. Technically |
|
They should also initialise to either of these values too, rather than 0.0. |
Consumers may compare to core_temp.*_INVALID constants.
|
Yeah I think that makes sense. I've made constants of them so users can use those. Although that means they should be floats in order for the typing to work out, which feels a bit off. I tense up when floats come up, should work out though since they're actually integers. It's a little wonky looking - I'm not sure if there's a more elegant solution short of doing a bunch of explicit conversions. |
|
Looks good. Thanks. |
Found and fixed a few issues with CoreTemperature:
Noneupon receiving invalid values according to specI'm not 100% sure about the handling of invalid values. Setting it to
Noneseems appropriate to me, but I'm not sure if it might have any unintended consequences down the line?