Fix protocol desynchronization in readSetDesktopSize#2124
Merged
CendioOssman merged 1 commit intoJun 30, 2026
Merged
Conversation
readSetDesktopSize() returned true instead of false when insufficient data was available, unlike every other message handler in SMsgReader. This caused the readMsg() state machine to reset to MSGSTATE_IDLE, leading to message boundary desynchronization when the remaining bytes arrived later — the first byte was consumed as a new message type rather than part of the pending SetDesktopSize message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readSetDesktopSize() returned true instead of false when insufficient data was available, unlike every other message handler in SMsgReader. This caused the readMsg() state machine to reset to MSGSTATE_IDLE, leading to message boundary desynchronization — the first byte of subsequent data was consumed as a new message type rather than part of the pending SetDesktopSize message.