Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Automated fix attempt
Fixes #583
Source issue: #583
Summary
All changes are consistent and correct.
Summary
Root cause: In
gateway.ts, thecreateAccesshandler silently defaultedtypeto"Event"when omitted ((input.type || "Event")). For HTTP functions, this produced a gateway access entry with the wrong type, causing all subsequent gateway requests to fail withFUNCTION_PARAM_INVALID.Changes made (2 files, 3 edits):
mcp/src/tools/gateway.ts:331-336— Added a validation guard that rejectscreateAccesscalls whentypeis missing. The error message explicitly states thattypeis required (Event or HTTP) and explains that omitting it causes the silent Event fallback that breaks HTTP functions.mcp/src/tools/gateway.ts:345— Removed the"Event"fallback default from the type-to-numeric mapping. Sincetypeis now validated as present above, the expression simplifies toinput.type === "HTTP" ? 6 : 1.mcp/src/tools/functions.ts:1024-1029— Strengthened thecreateAccessnextAction guidance returned after HTTP function creation. The reason now explicitly instructs the caller to passtype="HTTP",targetType="function", and the function name, and warns thattypemust not be omitted.mcp/src/tools/gateway.ts:352— Minor consistency fix: removed "或省略" from the error hint text since omitting type is no longer allowed.