Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Automated fix attempt
Fixes #568
Source issue: #568
Summary
All changes look correct. Let me also check the Claude skills mirror to see if it needs updating (per the rules, it's auto-synced, so I shouldn't edit it directly).
The changes are complete. Here's a summary:
Summary
Issue: Agents passed the project root as
functionRootPath(e.g.,/home/user/project) instead of thecloudfunctionsorfunctionsdirectory (e.g.,/home/user/project/cloudfunctions), causing the evaluator to fail because it expected code atcloudfunctions/hello/index.jsnothello/index.js.Changes made (4 files):
mcp/src/tools/functions.ts(main fix):functionRootPathdescription to explicitly say it must be the directory that directly contains function folders (likecloudfunctionsorfunctions), and to NOT pass the project root or the function subdirectory itself. Previously it only warned about the function subdirectory, not the project root.buildFunctionOperationErrorMessage, line ~372): Added logic that detects whenfunctionRootPathdoesn't end withcloudfunctionsorfunctionsand suggests the correct path (e.g.,/project/cloudfunctionsor/project/functions).paths[0]and HTTP function error hints to say "cloudfunctions 或 functions 目录的绝对路径,不是项目根目录" instead of the ambiguous "cloudfunctions 父目录".mcp/src/tools/functions.test.ts: Added two regression tests:functionRootPathdoesn't end withcloudfunctions/functionson path-not-found errors.functionRootPathalready correctly ends withcloudfunctions.config/source/skills/cloud-functions/SKILL.md: Updated the functionRootPath guidance to say "directory that directly contains function folders (e.g.,cloudfunctions/orfunctions/), NOT the project root and NOT the function subdirectory itself".doc/mcp-tools.md: Updated the generated docs table row forfunctionRootPathto match the new schema description.