omh-storage integration #4455
omh-storage integration #4455
4 new issues (0 max.) of at least severity.
Here is an overview of what got changed by this pull request:
Issues
======
+ Solved 4
- Added 4
Complexity increasing per file
==============================
- app/src/main/java/com/amaze/filemanager/ui/fragments/data/MainFragmentViewModel.kt 3
- app/src/main/java/com/amaze/filemanager/adapters/glide/cloudicon/CloudIconModelLoader.java 1
- app/src/main/java/com/amaze/filemanager/filesystem/HybridFileParcelable.java 7
- app/src/main/java/com/amaze/filemanager/adapters/data/IconDataParcelable.java 1
- app/src/main/java/com/amaze/filemanager/asynchronous/asynctasks/LoadFilesListTask.java 4
- app/src/main/java/com/amaze/filemanager/asynchronous/asynctasks/DeleteTask.java 1
- app/src/main/java/com/amaze/filemanager/application/AppConfig.java 1
- app/src/main/java/com/amaze/filemanager/filesystem/HybridFile.java 13
- app/src/main/java/com/amaze/filemanager/adapters/data/LayoutElementParcelable.java 4
- app/src/main/java/com/amaze/filemanager/utils/MainActivityHelper.java 3
- app/src/main/java/com/amaze/filemanager/ui/fragments/MainFragment.java 11
- app/src/main/java/com/amaze/filemanager/asynchronous/asynctasks/movecopy/MoveFiles.java 4
- app/src/test/java/com/amaze/filemanager/asynchronous/services/EncryptServiceTest.kt 2
- app/src/test/java/com/amaze/filemanager/filesystem/ssh/FilesOnSshdTest.kt 1
- app/src/main/java/com/amaze/filemanager/asynchronous/asynctasks/movecopy/PreparePasteTask.kt 2
- app/src/main/java/com/amaze/filemanager/utils/omh/OMHClientHelper.kt 50
- app/src/main/java/com/amaze/filemanager/filesystem/HybridFileOmhStorageExt.kt 20
- app/src/main/java/com/amaze/filemanager/utils/DataUtils.kt 67
- app/src/test/java/com/amaze/filemanager/utils/cloud/CloudPluginUtilTest.kt 1
- app/src/main/java/com/amaze/filemanager/utils/cloud/CloudPluginUtil.kt 17
- app/src/play/java/com/amaze/filemanager/asynchronous/asynctasks/cloud/CloudLoaderCallable.kt 13
- app/src/main/java/com/amaze/filemanager/ui/fragments/CloudSheetFragment.kt 18
- app/src/main/java/com/amaze/filemanager/filesystem/cloud/CloudUtil.kt 34
- app/src/main/java/com/amaze/filemanager/utils/StartActivityForResultWithSourceIntent.kt 5
- app/src/main/java/com/amaze/filemanager/utils/omh/OmhAuthClientExt.kt 23
- app/src/test/java/com/amaze/filemanager/ui/activities/MainActivityAuthTriggerTest.kt 19
- app/src/main/java/com/amaze/filemanager/utils/omh/OmhStorageClientExt.kt 16
- app/src/test/java/com/amaze/filemanager/utils/omh/OmhAuthClientExtTest.kt 77
- app/src/test/java/com/amaze/filemanager/filesystem/HybridFileOmhStorageExtTest.kt 33
- app/src/test/java/com/amaze/filemanager/utils/omh/OmhStorageClientExtTest.kt 28
Complexity decreasing per file
==============================
+ app/src/main/java/com/amaze/filemanager/filesystem/files/GenericCopyUtil.java -4
+ app/src/main/java/com/amaze/filemanager/filesystem/Operations.java -5
+ app/src/main/java/com/amaze/filemanager/ui/activities/MainActivity.java -18
+ app/src/main/java/com/amaze/filemanager/filesystem/files/FileUtils.java -3
+ app/src/main/java/com/amaze/filemanager/database/ExplorerDatabase.kt -1
+ app/src/main/java/com/amaze/filemanager/asynchronous/asynctasks/searchfilesystem/DeepSearch.kt -4
Clones added
============
- app/src/main/java/com/amaze/filemanager/adapters/data/LayoutElementParcelable.java 2
- app/src/main/java/com/amaze/filemanager/utils/MainActivityHelper.java 2
Clones removed
==============
+ app/src/main/java/com/amaze/filemanager/filesystem/Operations.java -22
See the complete overview on Codacy
Annotations
codacy-production / Codacy Static Code Analysis
app/src/main/java/com/amaze/filemanager/asynchronous/asynctasks/movecopy/MoveFiles.java#L165
Avoid throwing raw exception types.
Check warning on line 228 in app/src/main/java/com/amaze/filemanager/filesystem/cloud/CloudUtil.kt
codacy-production / Codacy Static Code Analysis
app/src/main/java/com/amaze/filemanager/filesystem/cloud/CloudUtil.kt#L228
The function getThumbnailInputStreamForCloud is too long (64). The maximum length is 60.
codacy-production / Codacy Static Code Analysis
app/src/main/java/com/amaze/filemanager/ui/fragments/data/MainFragmentViewModel.kt#L55
Private properties should be named in a self-explanatory manner without the need for a comment.
Check warning on line 340 in app/src/main/java/com/amaze/filemanager/utils/omh/OMHClientHelper.kt
codacy-production / Codacy Static Code Analysis
app/src/main/java/com/amaze/filemanager/utils/omh/OMHClientHelper.kt#L340
Expression with labels increase complexity and affect maintainability.