Fix stashing aliases with a space in double quotes#102
Open
sherpalabsio wants to merge 2 commits intoTarrasch:masterfrom
Open
Fix stashing aliases with a space in double quotes#102sherpalabsio wants to merge 2 commits intoTarrasch:masterfrom
sherpalabsio wants to merge 2 commits intoTarrasch:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
eval "__varstash_alias__$stash_name=\"$alias_def\""crashes in lib/varstash:111 when I want to stash an alias likealias some_alias='echo "ORIG ALIAS"'.The problem occurs when we have a space inside double quotes in the alias.
The fix
Escape double quotes.