Skip to content

[TASK] Use modern HTML syntax for boolean attributes #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
billdagou wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[TASK] Use modern HTML syntax for boolean attributes #1234

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49a4dcd
Behavior changes for `NULL`, `TRUE` and `FALSE`, and HTML5 support in…
billdagou Sep 5, 2025
86f9def
Rename `isXHtml` to `requireAttributeValues`
billdagou Sep 5, 2025
d3f3011
Non-breaking task for adjusted markup for `true` and `false`
billdagou Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions src/Core/ViewHelper/TagBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ class TagBuilder
protected bool $forceClosingTag = false;

protected bool $ignoreEmptyAttributes = false;
/**
* Specifies whether a value is required for boolean attributes
*/
protected bool $requireAttributeValues = true;

/**
* Constructor
Expand Down Expand Up @@ -168,6 +172,11 @@ public function ignoreEmptyAttributes(bool $ignoreEmptyAttributes): void
}
}

public function requireAttributeValues(bool $requireAttributeValues): void
{
$this->requireAttributeValues = $requireAttributeValues;
}

/**
* Adds an attribute to the $attributes-collection
*
Expand Down Expand Up @@ -213,16 +222,6 @@ public function addAttribute(string $attributeName, $attributeValue, bool $escap
$this->addAttribute($attributeName . '-' . $name, $value, $escapeSpecialCharacters);
}
} else {
// This should probably also check for null, but we can't do that for now because of backwards compatibility
if ($attributeValue === false) {
$this->removeAttribute($attributeName);
return;
}

if ($attributeValue === true) {
$attributeValue = $attributeName;
}

if ($attributeValue instanceof \BackedEnum) {
$attributeValue = (string)$attributeValue->value;
} elseif ($attributeValue instanceof \UnitEnum) {
Expand All @@ -232,7 +231,8 @@ public function addAttribute(string $attributeName, $attributeValue, bool $escap
if (trim((string)$attributeValue) === '' && $this->ignoreEmptyAttributes) {
return;
}
if ($escapeSpecialCharacters) {
// Escape non-boolean values
if (!is_bool($attributeValue) && $escapeSpecialCharacters) {
$attributeValue = htmlspecialchars((string)$attributeValue);
}
$this->attributes[$attributeName] = $attributeValue;
Expand Down Expand Up @@ -289,7 +289,15 @@ public function render(): string
}
$output = '<' . $this->tagName;
foreach ($this->attributes as $attributeName => $attributeValue) {
$output .= ' ' . $attributeName . '="' . $attributeValue . '"';
if ($attributeValue === true) {
if ($this->requireAttributeValues) {
$output .= ' ' . $attributeName . '="' . $attributeName . '"';
} else {
$output .= ' ' . $attributeName;
}
} elseif ($attributeValue !== false) {
$output .= ' ' . $attributeName . '="' . $attributeValue . '"';
}
}
if ($this->hasContent() || $this->forceClosingTag) {
$output .= '>' . $this->content . '</' . $this->tagName . '>';
Expand Down