Add status and json to response Issue #11#12
Open
justhamade wants to merge 6 commits into
Open
Conversation
Owner
|
@justhamade looks good - are there any tests we can add to verify this does what we expect it to? As an aside, I'm happy the lean on |
Author
|
Thanks for looking at the PR. I will write some tests as soon as I have time. One issue is that it may break backwards compatibility and not sure how you want to handle that. |
Owner
|
What change breaks backwards compatibility? |
Contributor
|
+1 for this functionality, how are those tests coming along? |
|
Have not gotten around to writing them, not sure if I will have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #11
Thanks to @SeanCannon