Skip to content

Fix/wait for keypress weird effect 4866#4876

Open
Gizmoobs wants to merge 6 commits intoStellarium:masterfrom
Gizmoobs:fix/waitForKeypress-weird-effect-4866
Open

Fix/wait for keypress weird effect 4866#4876
Gizmoobs wants to merge 6 commits intoStellarium:masterfrom
Gizmoobs:fix/waitForKeypress-weird-effect-4866

Conversation

@Gizmoobs
Copy link
Copy Markdown
Contributor

@Gizmoobs Gizmoobs commented Apr 15, 2026

waitForKeypress() was leaking so I added keyEvent->accept() and isAutoRepeat() to the function in hopes that it will complete the event before routing downstream. I also added a modifiable visual indicator on line 1029 in src/scripting/StelMainScriptAPI.cpp. This visual indicator displays a "Press any key to continue..." prompt that will show that the function is working as intended.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

Not tested locally.

Test Configuration:
Irrelevant

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions
Copy link
Copy Markdown

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

Files matching guide/**:

  • Did you remember to update screenshots to match new updates?
  • Did you remember to grammar check in changed part of documentation?

This is an automatically generated QA checklist based on modified files.

@Gizmoobs Gizmoobs force-pushed the fix/waitForKeypress-weird-effect-4866 branch from 718db2e to 4c63875 Compare April 15, 2026 21:37
@github-actions github-actions bot added the has conflicts The pull request has conflicts label Apr 15, 2026
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot removed the has conflicts The pull request has conflicts label Apr 15, 2026
@github-actions
Copy link
Copy Markdown

Conflicts have been resolved. A maintainer will review the pull request shortly.

@alex-w
Copy link
Copy Markdown
Member

alex-w commented Apr 16, 2026

But it works with pressing "Enter" key only (keyboard only navigation - I didn't check presenter at this moment)

@alex-w alex-w added this to Scripting Apr 16, 2026
@github-project-automation github-project-automation bot moved this to Backlog in Scripting Apr 16, 2026
@alex-w alex-w added subsystem: scripting The issue related to scripting engine of planetarium… purpose: interoperability Interoperability issues labels Apr 16, 2026
@alex-w alex-w added this to the 26.2 milestone Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

purpose: interoperability Interoperability issues subsystem: scripting The issue related to scripting engine of planetarium…

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants