Fix/wait for keypress weird effect 4866#4876
Open
Gizmoobs wants to merge 6 commits intoStellarium:masterfrom
Open
Fix/wait for keypress weird effect 4866#4876Gizmoobs wants to merge 6 commits intoStellarium:masterfrom
Gizmoobs wants to merge 6 commits intoStellarium:masterfrom
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
This is an automatically generated QA checklist based on modified files. |
718db2e to
4c63875
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Member
|
But it works with pressing "Enter" key only (keyboard only navigation - I didn't check presenter at this moment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
waitForKeypress() was leaking so I added keyEvent->accept() and isAutoRepeat() to the function in hopes that it will complete the event before routing downstream. I also added a modifiable visual indicator on line 1029 in src/scripting/StelMainScriptAPI.cpp. This visual indicator displays a "Press any key to continue..." prompt that will show that the function is working as intended.
Type of change
How Has This Been Tested?
Not tested locally.
Test Configuration:
Irrelevant
Checklist: