fix: ignore whitespace in store plugin search#935
Open
zdennisz wants to merge 1 commit into
Open
Conversation
Store search used plain substring matching, so a query like "tab master" would not match a plugin named "tabmaster". Normalize both the query and the searched fields (name, description, author, tags) by lowercasing and stripping whitespace before comparing. Resolves SteamDeckHomebrew#622 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please tick as appropriate:
Description
The plugin store search used plain substring matching, so a query like
tab masterwould not match a plugin namedtabmaster. This normalizes both the search query and the searched fields (name, description, author, tags) by lowercasing and stripping whitespace before comparing.Store search is performed entirely client-side (the remote store API returns the full list; only
sort_by/sort_directionare sent), so this fix is contained tofrontend/src/components/store/Store.tsx.Verification
pnpm run typecheck— cleantab master,tabmaster,css,cssloaderall matchTabMaster/CSS Loader; empty query still returns all plugins.Resolves #622