fix(macOS): fix macOS type checking and missing method#923
Open
giodotblue wants to merge 3 commits into
Open
Conversation
Fixes the code styling that pyright wasn't happy with Also adds _get_user_id which gets used in helpers.py Signed-off-by: Gianni Spadoni <me@gio.blue>
macOS can use the same flow as Linux here. Adds is_linux_or_mac (maybe should be is_posix?) Signed-off-by: Gianni Spadoni <me@gio.blue>
Plugins get stuck in a loop of loading infinitely on macOS The fix requires changes that might impact other platforms, so disable the feature for now Signed-off-by: Gianni Spadoni <me@gio.blue>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please tick as appropriate:
Description
This fixes issues related to backend macOS support
Fixes get_system_pythonpaths() in helpers.py and resolves the type checking failures
I've also found an issue with hot reloading on Mac, so I've disabled that and I'll make a PR (the fix is sorta large)