Skip to content

fix: validation of url fields #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakub206 wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −37
Open

fix: validation of url fields #359

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a9161a
fix: validation of url fields
jakub206 May 13, 2026
43a354b
fix: validation of url fields
jakub206 May 18, 2026
b3badc8
fix: better url validation
jakub206 May 25, 2026
3fe2129
Merge branch 'main' into fix/better-url-validation
jakub206 May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions package-lock.json
View file
Open in desktop
Copy link
Copy Markdown
Member

@michalges michalges May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-lock nie powinien ulec żadnym zmianom w pr'ce gdzie nie instalujesz nic nowego itp. Możesz ręcznie skopiować stary package-lock (z przed twoich zmian) i go z powrotem zacommitować, albo lepiej - wyszukaj sobie jak się "edytuje" commity (interactive rebase) (efekt będzie ten sam, ale ta druga metoda bardziej porządna + można się czegoś zawsze nauczyć)

na przyszłość po prostu nie dodawaj package-lock.json do commitów

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions src/schemas/optional-url-schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,8 @@ export const OptionalUrlSchema = z
.string()
.trim()
.url(FORM_ERROR_MESSAGES.INVALID_URL)
.startsWith("http://", {
Copy link
Copy Markdown
Member

@michalges michalges May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https zamiast http

message: FORM_ERROR_MESSAGES.INVALID_URL,
})
.or(z.literal(""))
.nullish();
4 changes: 3 additions & 1 deletion src/schemas/required-url-schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,6 @@ import { RequiredStringSchema } from "./required-string-schema";

export const RequiredUrlSchema = RequiredStringSchema.url(
FORM_ERROR_MESSAGES.INVALID_URL,
);
).startsWith("http://", {
message: FORM_ERROR_MESSAGES.INVALID_URL,
Copy link
Copy Markdown
Member

@michalges michalges May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ten błąd niewiele mówi użytkownikowi, może dodaj nowy w stylu "Adres URL powinien zaczynać się od https://"

});
Loading