Skip to content

removed depreciation from consignment apis #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chronos25 wants to merge 8 commits into
base: fixes/ritik/addedDeleteFieldForProductType
Choose a base branch
from
Open

removed depreciation from consignment apis #36

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0ff3978
removed depreciation from consignment apis
ritikatsp Aug 22, 2023
b6231e9
handle the new response
ritikatsp Sep 11, 2023
21ed534
replaced optional condition & const with var
ritikatsp Sep 26, 2023
5ceb36e
handle reponse and updated consignment_product endpoint
ritikatsp Sep 29, 2023
595411a
added catch block
ritikatsp Sep 30, 2023
c8e78d5
fix delete consignment api
ritikatsp Feb 16, 2024
6bf25b9
Replace size with length.
surajmandal04 Oct 23, 2024
553d737
Added product update api changes
surajmandal04 Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 21 additions & 14 deletions lib/consignment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ var fetchStockOrdersForSuppliers = function(args, connectionInfo, retryCounter)
log.debug('retry # ' + retryCounter);
}

var path = '/api/consignment';
var path = '/api/2.0/consignments';
var vendUrl = 'https://' + connectionInfo.domainPrefix + '.vendhq.com' + path;
var authString = 'Bearer ' + connectionInfo.accessToken;
log.debug('GET ' + vendUrl);
Expand All @@ -215,8 +215,9 @@ var fetchStockOrdersForSuppliers = function(args, connectionInfo, retryCounter)
page_size: args.pageSize.value // eslint-disable-line camelcase
}
};

return utils.sendRequest(options, args, connectionInfo, fetchStockOrdersForSuppliers, retryCounter);
const getOrdersFromSuppliers = utils.sendRequest(options, args, connectionInfo, fetchStockOrdersForSuppliers, retryCounter);
const result = getOrdersFromSuppliers?.data ? getOrdersFromSuppliers?.data : getOrdersFromSuppliers;

@kamal0808 kamal0808 Sep 12, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getOrdersFromSuppliers?.data || getOrdersFromSuppliers

return result;
};

// TODO: need to add a test
Expand Down Expand Up @@ -251,7 +252,7 @@ var fetchConsignment = function(args, connectionInfo, retryCounter) {
log.debug('retry # ' + retryCounter);
}

var path = '/api/1.0/consignment/' + args.apiId.value;
var path = '/api/2.0/consignments/' + args.apiId.value;

@kamal0808 kamal0808 Sep 12, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you considered creating a new path instead of replacing the existing ones?

@chronos25 chronos25 Sep 12, 2023

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No

var vendUrl = 'https://' + connectionInfo.domainPrefix + '.vendhq.com' + path;
log.debug('Requesting vend consignment ' + vendUrl);
var authString = 'Bearer ' + connectionInfo.accessToken;
Expand All @@ -264,8 +265,9 @@ var fetchConsignment = function(args, connectionInfo, retryCounter) {
'Accept': 'application/json'
}
};

return utils.sendRequest(options, args, connectionInfo, fetchConsignment, retryCounter);
const getConsignment = utils.sendRequest(options, args, connectionInfo, fetchConsignment, retryCounter);
const result = getConsignment?.data ? getConsignment?.data : getConsignment;
return result;
};

// TODO: need to add a test
Expand Down Expand Up @@ -513,7 +515,7 @@ var createStockOrder = function(args, connectionInfo, retryCounter) {
log.debug('retry # ' + retryCounter);
}

var path = '/api/consignment';
var path = '/api/2.0/consignment';
var vendUrl = 'https://' + connectionInfo.domainPrefix + '.vendhq.com' + path;
var authString = 'Bearer ' + connectionInfo.accessToken;

Expand Down Expand Up @@ -588,7 +590,7 @@ var markStockOrderAsSent = function(args, connectionInfo, retryCounter) {
log.debug('retry # ' + retryCounter);
}

var path = '/api/consignment/' + args.apiId.value;
var path = '/api/2.0/consignments/' + args.apiId.value;
var vendUrl = 'https://' + connectionInfo.domainPrefix + '.vendhq.com' + path;
var authString = 'Bearer ' + connectionInfo.accessToken;
var body = args.body.value;
Expand All @@ -606,8 +608,9 @@ var markStockOrderAsSent = function(args, connectionInfo, retryCounter) {
};
log.debug(options.method + ' ' + options.url);
log.debug( { message: 'body', body: options.json } );

return utils.sendRequest(options, args, connectionInfo, markStockOrderAsSent, retryCounter);
const updateConsignmentToSent = utils.sendRequest(options, args, connectionInfo, markStockOrderAsSent, retryCounter);
const result = updateConsignmentToSent?.data ? updateConsignmentToSent?.data : updateConsignmentToSent;
return result;
};

var markStockOrderAsReceived = function(args, connectionInfo, retryCounter) {
Expand All @@ -623,7 +626,7 @@ var markStockOrderAsReceived = function(args, connectionInfo, retryCounter) {
log.debug('retry # ' + retryCounter);
}

var path = '/api/consignment/' + args.apiId.value;
var path = '/api/2.0/consignments/' + args.apiId.value;
var vendUrl = 'https://' + connectionInfo.domainPrefix + '.vendhq.com' + path;
var authString = 'Bearer ' + connectionInfo.accessToken;
var body = args.body.value;
Expand All @@ -642,7 +645,9 @@ var markStockOrderAsReceived = function(args, connectionInfo, retryCounter) {
log.debug(options.method + ' ' + options.url);
log.debug( { message: 'body', body: options.json } );

return utils.sendRequest(options, args, connectionInfo, markStockOrderAsReceived, retryCounter);
const updateConsignmentToReceived = utils.sendRequest(options, args, connectionInfo, markStockOrderAsReceived, retryCounter);
const result = updateConsignmentToReceived?.data ? updateConsignmentToReceived?.data : updateConsignmentToReceived;
return result;
};

var deleteStockOrder = function(args, connectionInfo, retryCounter) {
Expand All @@ -659,7 +664,7 @@ var deleteStockOrder = function(args, connectionInfo, retryCounter) {
}

log.debug(args.apiId.value);
var path = '/api/consignment/' + args.apiId.value;
var path = '/api/2.0/consignments/' + args.apiId.value;
log.debug(path);
var vendUrl = 'https://' + connectionInfo.domainPrefix + '.vendhq.com' + path;
var authString = 'Bearer ' + connectionInfo.accessToken;
Expand All @@ -675,7 +680,9 @@ var deleteStockOrder = function(args, connectionInfo, retryCounter) {
};
log.debug(options.method + ' ' + options.url);

return utils.sendRequest(options, args, connectionInfo, deleteStockOrder, retryCounter);
const consignmentDelete = utils.sendRequest(options, args, connectionInfo, deleteStockOrder, retryCounter);
const result = consignmentDelete?.data ? consignmentDelete?.data : consignmentDelete;
return result;
};

var deleteConsignmentProduct = function(args, connectionInfo, retryCounter) {
Expand Down